Updated _misplaced_members for PySide6 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks! Yes, this is the way, except we also need them for PyQt4 and PyQt5. It's hard to miss right now.. And tests won't pick this up.. But if they aren't there, then they simply would not get added to Qt.py when using those. Could you add these to PyQt4 and 5 as well? |
|
Added. Also added to PySide. I couldn't find API docs for PyQt4, but I believe it should be a match for PySide 1, so I referenced those API docs. Interesting that they flip-flopped on the location of these members. |
|
Looks good, thanks @johnsonthomassonttf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time listener, first time caller from The Third Floor
I located these 4 members in PySide6 and based this modification on similar commits. Please let me know if there's a better way to do this. We're actively testing in PySide6 and PySide2, so I may discover more misplaced members.