Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr #2

Closed
wants to merge 2 commits into from
Closed

Pr #2

wants to merge 2 commits into from

Conversation

mosuem
Copy link
Owner

@mosuem mosuem commented Nov 28, 2024

No description provided.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl None 0.20.1 0.20.2 0.20.1 ✔️
Changelog Entry
Package Changed Files
package:intl pkgs/intl/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
intl StringStack
DateBuilder

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Copy link

github-actions bot commented Nov 28, 2024

Ecosystem testing

Package Solve Analyze Test
my_app_old_web ✅/❌ ✅/✅ -/-
my_app_new_web ✅/✅ ✅/✅ ✅/✅
Details per app
my_app_old_web

The failure occured at solve, this is the error output of that step:

Because every version of intl from git depends on web ^1.1.0 and my_app_old_web depends on web ^0.5.0, intl from git is forbidden.
So, because my_app_old_web depends on intl from git, version solving failed.

The complete list of logs is:

Logs for solve

Before:

StdOut:

Resolving dependencies...
Downloading packages...
  characters 1.3.0 (1.3.1 available)
  collection 1.19.0 (1.19.1 available)
  intl 0.19.0 (0.20.1 available)
  matcher 0.12.16+1 (0.12.17 available)
  material_color_utilities 0.11.1 (0.12.0 available)
  meta 1.15.0 (1.16.0 available)
  test_api 0.7.3 (0.7.4 available)
  web 0.5.1 (1.1.0 available)
Got dependencies!
8 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.

StdErr:


After:

StdOut:

"intl" is already in "dependencies". Will try to update the constraint.

StdErr:

Because every version of intl from git depends on web ^1.1.0 and my_app_old_web depends on web ^0.5.0, intl from git is forbidden.
So, because my_app_old_web depends on intl from git, version solving failed.

Logs for analyze

Before:

StdOut:

Analyzing my_app_old_web...                                     
No issues found! (ran in 9.3s)

StdErr:


After:

StdOut:

Analyzing my_app_old_web...                                     
No issues found! (ran in 6.8s)

StdErr:


my_app_new_web

The app tests passed!

The complete list of logs is:

Logs for solve

Before:

StdOut:

Resolving dependencies...
Downloading packages...
  characters 1.3.0 (1.3.1 available)
  collection 1.19.0 (1.19.1 available)
  intl 0.19.0 (0.20.1 available)
  matcher 0.12.16+1 (0.12.17 available)
  material_color_utilities 0.11.1 (0.12.0 available)
  meta 1.15.0 (1.16.0 available)
  test_api 0.7.3 (0.7.4 available)
Got dependencies!
7 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.

StdErr:


After:

StdOut:

"intl" is already in "dependencies". Will try to update the constraint.
Resolving dependencies...
Downloading packages...
  characters 1.3.0 (1.3.1 available)
  collection 1.19.0 (1.19.1 available)
+ http 1.2.2
+ http_parser 4.1.1
* intl 0.20.2 from git https://github.com/mosuem/i18n at 4989a7 in pkgs/intl (was 0.19.0)
  matcher 0.12.16+1 (0.12.17 available)
  material_color_utilities 0.11.1 (0.12.0 available)
  meta 1.15.0 (1.16.0 available)
  test_api 0.7.3 (0.7.4 available)
+ typed_data 1.4.0
Changed 4 dependencies!
6 packages have newer versions incompatible with dependency constraints.
Try `dart pub outdated` for more information.

StdErr:


Logs for analyze

Before:

StdOut:

Analyzing my_app_new_web...                                     
No issues found! (ran in 1.6s)

StdErr:


After:

StdOut:

Analyzing my_app_new_web...                                     
No issues found! (ran in 1.5s)

StdErr:


Logs for test

Before:

StdOut:


✅ Counter increments smoke test

🎉 1 test passed.

StdErr:


After:

StdOut:


✅ Counter increments smoke test

🎉 1 test passed.

StdErr:


@mosuem
Copy link
Owner Author

mosuem commented Nov 28, 2024

Ecosystem testing

Package Solve Analyze Test
my_app_old_web ✅/❌ ✅/✅ -/-
my_app_new_web ✅/❌ ✅/✅ ✅/✅

cc @devoncarew

Repository owner deleted a comment from github-actions bot Dec 2, 2024
@mosuem mosuem mentioned this pull request Dec 3, 2024
1 task
mosuem added a commit to dart-lang/ecosystem that referenced this pull request Dec 5, 2024
Workflow for testing a package upgrade against the ecosystem.

See for example
mosuem/i18n#2 (comment)

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Most changes should add an entry to the changelog and may need to [rev
the pubspec package
version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding
tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs -
please allow for some latency before initial review feedback.
</details>
@mosuem mosuem closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant