-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr #2
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR).
API leaks
|
Package | Leaked API symbols |
---|---|
intl | StringStack DateBuilder |
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Ecosystem testing
Details per appmy_app_old_web ❌The failure occured at solve, this is the error output of that step:
The complete list of logs is: Logs for solveBefore:StdOut:
StdErr:
After:StdOut:
StdErr:
Logs for analyzeBefore:StdOut:
StdErr:
After:StdOut:
StdErr:
my_app_new_web ✅The app tests passed! The complete list of logs is: Logs for solveBefore:StdOut:
StdErr:
After:StdOut:
StdErr:
Logs for analyzeBefore:StdOut:
StdErr:
After:StdOut:
StdErr:
Logs for testBefore:StdOut:
StdErr:
After:StdOut:
StdErr:
|
cc @devoncarew |
Workflow for testing a package upgrade against the ecosystem. See for example mosuem/i18n#2 (comment) --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
No description provided.