Fix wasm casting error (flutter#8474)

mossmana · Oct 31, 2024 · 7bd46dc · 7bd46dc
1 parent 48fc9aa
commit 7bd46dc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/packages/devtools_app/lib/src/screens/logging/logging_controller.dart b/packages/devtools_app/lib/src/screens/logging/logging_controller.dart
@@ -423,7 +423,7 @@ class LoggingController extends DisposableController
     final message = jsonEncode(event);
     log(
       LogData(
-        'gc',
+        _gcFilterId,
         message,
         e.timestamp,
         summary: summary,

diff --git a/packages/devtools_app/lib/src/screens/logging/metadata.dart b/packages/devtools_app/lib/src/screens/logging/metadata.dart
@@ -80,12 +80,16 @@ class MetadataChips extends StatelessWidget {
     // Prepare frame time chip.
     String? elapsedFrameTimeAsString;
     try {
-      final int micros = (jsonDecode(data.details!) as Map)['elapsed'];
-      elapsedFrameTimeAsString = durationText(
-        Duration(microseconds: micros),
-        unit: DurationDisplayUnit.milliseconds,
-        fractionDigits: 2,
-      );
+      if (data.details != null) {
+        final int? micros = (jsonDecode(data.details!) as Map)['elapsed'];
+        if (micros != null) {
+          elapsedFrameTimeAsString = durationText(
+            Duration(microseconds: micros),
+            unit: DurationDisplayUnit.milliseconds,
+            fractionDigits: 2,
+          );
+        }
+      }
     } catch (e) {
       // Ignore exception; [elapsedFrameTimeAsString] will be null.
     }