Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some OAuth related issues #233

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix some OAuth related issues #233

merged 1 commit into from
Jul 3, 2024

Conversation

rockwood-openai
Copy link
Contributor

  • Add logging for config issues
  • oauth callback expiration should be milliseconds not microseconds
  • Return on error early during oauth callback
  • Prevent no config from throwing exception constructing string

@rockwood-openai
Copy link
Contributor Author

FYI @kenneth-jia

@kenneth-jia
Copy link
Contributor

Hi, @rockwood-openai Thank you for your contribute! The fix looks good!
The tricky part is I have no privilege to approve the PR (though I'm the author but I'm not a maintainer anymore).
Let me discuss with my colleagues and find a way out.😅

@alex-q-chen alex-q-chen self-requested a review June 11, 2024 09:49
@rockwood-openai
Copy link
Contributor Author

Thanks @kenneth-jia and @alex-q-chen

I think CI is broken based on #232 let me know if there is anything I can do to help.

@rockwood-openai @alex-q-chen
Fix some OAuth related issues
59d56ab 
* Add logging for config issues
* oauth callback expiration should be milliseconds not microseconds
* Return on error early during oauth callback
* Prevent no config from throwing exception constructing string
@alex-q-chen alex-q-chen merged commit 122678e into morganstanley:main Jul 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-q-chen alex-q-chen alex-q-chen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockwood-openai @kenneth-jia @alex-q-chen