Improve for Bazel deps

morganstanley · Apr 11, 2022 · 08603f5 · 08603f5
1 parent 3c6197c
commit 08603f5
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 4 deletions.
diff --git a/BUILD → BUILD.bazel b/BUILD → BUILD.bazel
@@ -5,7 +5,7 @@ cc_library(
 
     includes = ["include"],
 
-    linkopts = ["-lpthread", "-lrdkafka"],
+    linkopts = ["-lpthread"],
 
     visibility = ["//visibility:public"],
 )

diff --git a/customrules/BUILD → customrules/BUILD.bazel b/customrules/BUILD → customrules/BUILD.bazel
diff --git a/examples/BUILD → examples/BUILD.bazel b/examples/BUILD → examples/BUILD.bazel
@@ -3,6 +3,8 @@ cc_binary(
 
     srcs = ["kafka_sync_producer.cc"],
 
+    linkopts = ["-lrdkafka"],
+
     deps = ["//:modern-cpp-kafka-api"],
 )
 
@@ -11,6 +13,8 @@ cc_binary(
 
     srcs = ["kafka_async_producer_copy_payload.cc"],
 
+    linkopts = ["-lrdkafka"],
+
     deps = ["//:modern-cpp-kafka-api"],
 )
 
@@ -19,6 +23,8 @@ cc_binary(
 
     srcs = ["kafka_async_producer_not_copy_payload.cc"],
 
+    linkopts = ["-lrdkafka"],
+
     deps = ["//:modern-cpp-kafka-api"],
 )
 
@@ -27,6 +33,8 @@ cc_binary(
 
     srcs = ["kafka_auto_commit_consumer.cc"],
 
+    linkopts = ["-lrdkafka"],
+
     deps = ["//:modern-cpp-kafka-api"],
 )
 
@@ -35,6 +43,8 @@ cc_binary(
 
     srcs = ["kafka_manual_commit_consumer.cc"],
 
+    linkopts = ["-lrdkafka"],
+
     deps = ["//:modern-cpp-kafka-api"],
 )
 
diff --git a/tests/BUILD → tests/BUILD.bazel b/tests/BUILD → tests/BUILD.bazel
@@ -8,6 +8,8 @@ cc_test(
             "@gtest//:gtest_main",
             "@rapidjson//:rapidjson"],
 
+    linkopts = ["-lrdkafka"],
+
     timeout = "short",
 
     tags = ["unit"],
@@ -23,6 +25,8 @@ cc_test(
             "@gtest//:gtest",
             "@gtest//:gtest_main"],
 
+    linkopts = ["-lrdkafka"],
+
     timeout = "long",
     shard_count = 8,
 
@@ -38,6 +42,8 @@ cc_test(
             "@gtest//:gtest",
             "@gtest//:gtest_main"],
 
+    linkopts = ["-lrdkafka"],
+
     timeout = "long",
     shard_count = 1,
 

diff --git a/tools/BUILD → tools/BUILD.bazel b/tools/BUILD → tools/BUILD.bazel
@@ -3,7 +3,7 @@ cc_binary(
 
     srcs = ["KafkaTopics.cc"],
 
-    linkopts = ["-lboost_program_options"],
+    linkopts = ["-lboost_program_options", "-lrdkafka"],
 
     deps = ["//:modern-cpp-kafka-api"],
 )
@@ -13,7 +13,7 @@ cc_binary(
 
     srcs = ["KafkaConsoleConsumer.cc"],
 
-    linkopts = ["-lboost_program_options"],
+    linkopts = ["-lboost_program_options", "-lrdkafka"],
 
     deps = ["//:modern-cpp-kafka-api"],
 )
@@ -23,7 +23,7 @@ cc_binary(
 
     srcs = ["KafkaConsoleProducer.cc"],
 
-    linkopts = ["-lboost_program_options"],
+    linkopts = ["-lboost_program_options", "-lrdkafka"],
 
     deps = ["//:modern-cpp-kafka-api"],
 )