-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports tags filter for nodes #741
Conversation
@bugout-dev check
|
I tested locally using the modifications on this branch: #747 My config ( [
{
"blockchain": "ethereum",
"endpoint": "<Infura URL>",
"tags": ["infura"]
},
{
"blockchain": "polygon",
"endpoint": "<Infura URL>",
"tags": ["infura"]
},
{
"blockchain": "polygon",
"endpoint": "<Alchemy URL>",
"tags": ["alchemy"]
}
] When I ran this request, I sometimes got the Infura URL in the curl -v --request POST "http://127.0.0.1:8544/nb/polygon/jsonrpc?access_id=$NB_CONTROLLER_ACCESS_ID&data_source=blockchain&tags=alchemy" \
--header 'Content-Type: application/json' \
--data-raw '{
"jsonrpc":"2.0",
"method":"eth_blockNumber",
"id":1
}' Am I using the wrong query parameter? |
@kompotkot : I think it needs documentation for how to use tags, and I think you can probably also write unit tests for the node selection function. The unit tests are currently failing. This should be fixed, as well. If necessary, remove tests, but there should be a working test framework. |
@kompotkot : My bad. I was using This request is working well: curl -v --request POST "http://127.0.0.1:8544/nb/polygon/jsonrpc?access_id=$NB_CONTROLLER_ACCESS_ID&data_source=blockchain&tag=alchemy" \
--header 'Content-Type: application/json' \
--data-raw '{
"jsonrpc":"2.0",
"method":"eth_blockNumber",
"id":1
}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct
Changes
Nobebalancer support of filter by tag.
How to test these changes?
Tested locally
Related issues