This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Fixes for IPv6 and multiple address records #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ab40ac added processing for IPv6 addresses, but the did not actually run for IPv6 (AAAA) records.
If there are multiple IP address records OnQueryRecordReply() will be called multiple times, but calling sdRef.Deallocate() after the first record will prevent further invocations of the callback.
Moved firing the Resolved event from OnQueryRecordReply() to OnResolveReply() so that it will fire only once after all IPv4 and IPv6 addresses (subject to AddressProtocol property) have been processed. Previously it would be fired once for each address as it was added to the [cumulative] AddressList.
cerebrate
added a commit
to arkane-systems/Arkane.Zeroconf
that referenced
this pull request
Apr 30, 2017
cerebrate
added a commit
to arkane-systems/Arkane.Zeroconf
that referenced
this pull request
Apr 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for IPv6 and multiple address records.