Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-6610): replace feature flag symbols with internal properties #4354

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

refactor(NODE-6610): replace feature flag symbols with internal properties #4354

wants to merge 7 commits into from

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Dec 13, 2024 •
edited by nbbeeken
Loading

Description

What is changing?

  • replace symbol options with string ones
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Our perf testing supports configuration via a JSON string, switching to internal string options means we can use this system to enable the yet to be released features for perf testing.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

addaleax
addaleax reviewed Dec 13, 2024
View reviewed changes
src/cmap/connection.ts Outdated Show resolved Hide resolved
src/cmap/wire_protocol/responses.ts Outdated Show resolved Hide resolved
@W-A-James W-A-James added the wip label Dec 13, 2024
@nbbeeken nbbeeken changed the title fix(NODE-6610): replace feature flag symbols with internal properties refactor(NODE-6610): replace feature flag symbols with internal properties Dec 16, 2024
@nbbeeken nbbeeken marked this pull request as ready for review December 17, 2024 20:34
@nbbeeken nbbeeken removed the wip label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W-A-James @addaleax @nbbeeken