MONGOID-5809: remove ruby -w warnings #5921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshanaVenkatesh
force-pushed
the
5809-remove-ruby-warnings
branch
from
45ed9a3 to
7857378
Compare
jamis
requested changes
Dec 16, 2024
lib/mongoid/serializable.rb
Outdated
Comment on lines
16
to
17
| remove_method :include_root_in_json if method_defined?(:include_root_in_json) | ||
| remove_method :include_root_in_json= if method_defined?(:include_root_in_json=) |
There was a problem hiding this comment.
Nice! I had to dig a bit to understand that these methods are defined in ActiveModel, and we're just re-defining them here to account for our default value Mongoid.include_root_in_json. Maybe add a comment to that effect?
Also, there's an extra space before these lines -- we've standardized on indentations in 2-space increments.
lib/mongoid/traversable.rb
Outdated
| class << self | ||
| remove_method :discriminator_key if method_defined?(:discriminator_key) |
There was a problem hiding this comment.
Same here -- please add a comment explaining that the preceding class_attribute creates both a getter and a setter, but we need to reimplement the getter (by delegating).
Also, the if method_defined?(...) is unnecessary here, since we know that the preceding class_attribute ensures the method is defined. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MONGOID-5809
When run with ruby -w, Mongoid is fairly noisy and provides complaints about method redefinitions and overrides. Remove warnings by preventing redefinition.
Original Warnings:
