MONGOID-5782 Ensure embedded documents are also marked timeless #5912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamis
approved these changes
Dec 9, 2024
|
Noting for posterity: as @DarshanaVenkatesh and I discussed elsewhere, this solution does not properly handle deeply nested children. There is a bug that we discovered in the callback code that results in callbacks on nested children being invoked twice, which defeats the timeless code because the first invocation resets timeless on the nested children, allowing the second one to actually update the timestamps, which propagates the change back up to the parent(s). |
jamis
requested changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MONGOID-5782
When a parent doc is set to timeless, this should also keep the embedded document as timeless. This is a bug fix as previously, the updated_at time would get set to current.