Fix escape key logic for popover components in Modal #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab3ec13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +27 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Oct 30, 2024
| @@ -82,9 +82,11 @@ const ModalView = React.forwardRef( | |||
| ? { | |||
| initialFocus: `#${id} ${initialFocus}`, | |||
| fallbackFocus: `#${closeId}`, | |||
| escapeDeactivates: false, | |||
shaneeza
reviewed
Oct 30, 2024
There was a problem hiding this comment.
It looks like the focus trap is not working after hitting esc: https://jmp.sh/AnGePGEd. On esc, the focus goes to the date picker trigger. If I hit tab, the focus moves to the close button, and another tab moves the focus outside the modal.
And in this recording, the focus moves to the original trigger if i hit esc when a select is open: https://jmp.sh/P70W5mcO
shaneeza
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes🧪 How to test changes
Main branch chromatic instance (broken focus trap): https://642700aa3e49e32bdbf0b0fc-vclacfpgcn.chromatic.com/?path=/story/components-datepicker-datepicker--in-modal
Open this PR's chromatic instance from build checks and in
DatePicker/InModalstorybook example: