LG-4338: Normalizes Modal size property (#2402)

* with changeset * Simpllify check
mongodb · Jun 18, 2024 · ccf18a5 · ccf18a5
1 parent a94306a
commit ccf18a5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/moody-dancers-refuse.md b/.changeset/moody-dancers-refuse.md
@@ -0,0 +1,5 @@
+---
+'@leafygreen-ui/modal': patch
+---
+
+Ensures Modal size property value is always normalized, such that if a value is passed that falls outside of those allowed, we default to `"default"`.
diff --git a/packages/modal/src/Modal/ModalView.tsx b/packages/modal/src/Modal/ModalView.tsx
@@ -43,7 +43,7 @@ const ModalView = React.forwardRef(
   (
     {
       open = false,
-      size = ModalSize.Default,
+      size: sizeProp = ModalSize.Default,
       setOpen = () => {},
       shouldClose = () => true,
       closeIconColor = CloseIconColor.Default,
@@ -87,6 +87,9 @@ const ModalView = React.forwardRef(
           fallbackFocus: `#${closeId}`, // tests fail without a fallback. (https://github.com/focus-trap/focus-trap-react/issues/91)
         };
 
+    const allowedSize = Object.values(ModalSize).includes(sizeProp);
+    const size = allowedSize ? sizeProp : ModalSize.Default;
+
     return (
       <Transition
         in={open}