Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark icons - master #3376

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Dark icons - master #3376

merged 2 commits into from
Aug 30, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Aug 30, 2024

Pull Request Info - SDK Docs Consolidation

Jira ticket: https://jira.mongodb.org/browse/DOP-4942

Use dark icons with their CMS names instead of image files. This gives both light and dark mode automatically.

Staging Links

Staging

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for device-sdk ready!

Name Link
🔨 Latest commit e58f3a7
🔍 Latest deploy log https://app.netlify.com/sites/device-sdk/deploys/66d1e86beb069d00089b59d1
😎 Deploy Preview https://deploy-preview-3376--device-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 30, 2024

Readability for Commit Hash: e58f3a7

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/dotnet: Grade Level: 9.1, Reading Ease: 51.04
  • source/sdk/kotlin: Grade Level: 9.2, Reading Ease: 50.63
  • source/sdk/java: Grade Level: 9.1, Reading Ease: 51.04
  • source/sdk/flutter: Grade Level: 9.5, Reading Ease: 50.02
  • source/sdk/swift: Grade Level: 9.4, Reading Ease: 50.12
  • source/sdk/react-native: Grade Level: 10.9, Reading Ease: 40.95
  • source/sdk/node: Grade Level: 8.6, Reading Ease: 52.15
  • source/sdk/cpp: Grade Level: 9.1, Reading Ease: 50.94

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

@docs-builder-bot
Copy link

docs-builder-bot commented Aug 30, 2024

@mmeigs mmeigs marked this pull request as ready for review August 30, 2024 16:16
Copy link
Collaborator

@krollins-mdb krollins-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mmeigs!

@mmeigs mmeigs merged commit 020e8f6 into master Aug 30, 2024
11 checks passed
@mmeigs mmeigs deleted the DOP-4942-dark-icons-realm-master branch August 30, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants