Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43495-schema-command #97

Merged
merged 13 commits into from
Oct 15, 2024
Merged

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Oct 9, 2024

DESCRIPTION

Adds a page on the /schema GitHub Copilot command

STAGING

https://deploy-preview-97--docs-mongodb-vscode.netlify.app/copilot-schema/
https://deploy-preview-97--docs-mongodb-vscode.netlify.app/copilot/

JIRA

https://jira.mongodb.org/browse/DOCSP-43495

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for docs-mongodb-vscode ready!

Name Link
🔨 Latest commit b1c8955
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongodb-vscode/deploys/670eaf8c4f9f5200089e2365
😎 Deploy Preview https://deploy-preview-97--docs-mongodb-vscode.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🔴 down 3 from production)
Accessibility: 91 (no change from production)
Best Practices: 75 (no change from production)
SEO: 69 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ltran-mdb2 ltran-mdb2 changed the title Docsp 43495 DOCSP-43495-schema-command Oct 9, 2024
Copy link
Contributor

@jason-price-mongodb jason-price-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltran-mdb2 please see comments. Thanks!

:depth: 1

The ``/schema`` command provides information about your collection
schema. The |copilot| accesses your connected MongoDB deployment to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rewrite in form "To XXX, the YYY."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this section to simplify!

--------

Provide a Sample Document
~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rewrite to not use just one nested heading.

Also, we typically require the use of numbered steps for examples now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Because this is a UI example instead of a code example, there is only 1 step (asking the copilot chat) so I left out numbers

Provide a Sample Document
~~~~~~~~~~~~~~~~~~~~~~~~~

Consider the ``users`` collection in the `Mflix Sample Database
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rewrite this to not use "Consider" because what is reader being asked to consider?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


Consider the ``users`` collection in the `Mflix Sample Database
<https://www.mongodb.com/docs/atlas/sample-data/sample-mflix/#sample_mflix.users>`__.
If you are connected to a MongoDB deployment that contains this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What about readers who don't have that sample? I checked that page, and it doesn't have an actual command to create the collection if they don't have it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a sample document to illustrate the collection schema. Because this is a UI example as opposed to a code example, I would recommend using the sample database to ensure consistency over having the user be able to replicate the exact example environment

Sure, here is a sample document from the sample_mflix.users
collection:

{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the Atlas samples page, and it shows the sample doc as:

{

"_id": {
"$oid": "59b99db4cfa9a34dcd7885b6"
},
"name": "Ned Stark",
"email": "[email protected]",
"password": "$2b$12$UREFwsRUoyF0CRqGNK0LzO0HM/jLhgUCNNIJ9RJAqMUQ74crlJ1Vu"
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this document to illustrate the collection schema!

"preferences": {}
}

Once Copilot generates the response, you can open the JSON output to see
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider "After", not "Once".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@ltran-mdb2
Copy link
Collaborator Author

Thanks for your feedback @jason-price-mongodb ! Could you take another look when you get a chance?

Copy link
Contributor

@jason-price-mongodb jason-price-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltran-mdb2 LGTM. Cheers.

@ltran-mdb2 ltran-mdb2 merged commit 1470ff3 into mongodb:master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants