DOCSP-27817 fix facet type to facet name per DOP #908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccho-mongodb
approved these changes
Sep 20, 2023
source/java-drivers.txt
Outdated
| @@ -7,11 +7,11 @@ MongoDB Java Drivers | |||
| .. default-domain:: mongodb | |||
|
|
|||
| .. facet:: | |||
| :type: programming_language | |||
| :name: programming_language | |||
There was a problem hiding this comment.
Suggestion:
I think these should be indented one more space, similar to the facet attributes in the pymongo.txt file in this PR.
spacing fix (3 spaces instead of 2) Co-authored-by: Chris Cho <[email protected]>
sarahemlin
commented
Sep 21, 2023
There was a problem hiding this comment.
@ccho-mongodb I think this one is ready to merge now. Thank you!
|
Hi @sarahemlin. I've made the same changes already in another merged PR, so closing this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @caitlindavey & @mongoKart,
I found out from DOP that the facet syntax should be :name: instead of :type:, so here are fixes to the affected docs-ecosystem files.
Thank you!
Sarah
JIRA - https://jira.mongodb.org/browse/DOCSP-27817