(DOCSP-32303) includes info about connecting an application using driver to atlas #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @carriecwk Can you include a link to the build? It also looks like a Vale check is failing, please take a look |
|
Would it be possible to incorporate the copy feedback from this review? Thanks! |
sarahsimpers
reviewed
Oct 9, 2023
source/python.txt
Outdated
Comment on lines
38
to
44
| - `{+atlas+} | ||
| <https://www.mongodb.com/docs/atlas?tck=docs_server>`__: The fully | ||
| managed service for MongoDB deployments in the cloud | ||
| - :ref:`MongoDB Enterprise <install-mdb-enterprise>`: The | ||
| subscription-based, self-managed version of MongoDB | ||
| - :ref:`MongoDB Community <install-mdb-community-edition>`: The | ||
| source-available, free-to-use, and self-managed version of MongoDB |
There was a problem hiding this comment.
Hi @carriecwk, thanks for this change! Since this PR was opened I merged #910, which added an include we could use here. Could you please replace the bullets with the include? With that change this is good to go from me, thanks!
Suggested change
| - `{+atlas+} | |
| <https://www.mongodb.com/docs/atlas?tck=docs_server>`__: The fully | |
| managed service for MongoDB deployments in the cloud | |
| - :ref:`MongoDB Enterprise <install-mdb-enterprise>`: The | |
| subscription-based, self-managed version of MongoDB | |
| - :ref:`MongoDB Community <install-mdb-community-edition>`: The | |
| source-available, free-to-use, and self-managed version of MongoDB | |
| .. include:: /includes/fact-environments.rst |
carriecwk
force-pushed
the
DOCSP-32303
branch
from
459ed37
to
ce7fc40
Compare
MatteoVH
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-32303
Staging - https://preview-mongodbcarriecwk.gatsbyjs.io/drivers/DOCSP-32303/python/
Build - https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=6525b179885de6b26b4f0d69
Self-Review Checklist