Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-30911: Server lifecycle support admonition #905

Merged
merged 10 commits into from
Sep 21, 2023

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Sep 13, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-30911
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left a question and a suggestion

source/includes/lifecycle-schedule-callout.rst Outdated Show resolved Hide resolved
source/includes/lifecycle-schedule-callout.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but fix Swift page issue

source/swift.txt Outdated
Comment on lines 126 to 127
The compatibility table in this section specifies the recommended version or
versions of the MongoDB C driver for use with a specific version of MongoDB.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I: This sentence mentions the C driver but is on the Swift page
S: double check all copied content to make sure driver matches

@ccho-mongodb ccho-mongodb merged commit 5e36ceb into mongodb:master Sep 21, 2023
1 check failed
@ccho-mongodb ccho-mongodb deleted the DOCSP-30911-server-support branch September 21, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants