Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-42973-fix-build-errors #674

Merged

Conversation

gmiller-mdb
Copy link
Contributor

@gmiller-mdb gmiller-mdb commented Sep 30, 2024

DESCRIPTION

fixing build errors

STAGING

https://deploy-preview-674--docs-compass.netlify.app/indexes/

JIRA

https://jira.mongodb.org/browse/DOCSP-43970

BUILD LOG

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit cafe83a
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/66fc00f006886c00096d2d16
😎 Deploy Preview https://deploy-preview-674--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gmiller-mdb gmiller-mdb changed the title fixing spacing DOCSP-42973-fix-build-errors Sep 30, 2024
Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmiller-mdb, thanks for this update. I spotted a small issue in staging. Lmk if you want to discuss!

{
"product_attributes.elements" : 1,
"product_attributes.resistance" : 1
}

If your index field name is ``$**``, your index only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this text is appearing in the code block, rather than after it. I think we might need to adjust the indentation here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-allen-mongo think I fixed it!

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeff-allen-mongo jeff-allen-mongo merged commit 1ceba09 into mongodb:master Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants