-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-42973-fix-build-errors #674
DOCSP-42973-fix-build-errors #674
Conversation
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmiller-mdb, thanks for this update. I spotted a small issue in staging. Lmk if you want to discuss!
{ | ||
"product_attributes.elements" : 1, | ||
"product_attributes.resistance" : 1 | ||
} | ||
|
||
If your index field name is ``$**``, your index only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this text is appearing in the code block, rather than after it. I think we might need to adjust the indentation here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeff-allen-mongo think I fixed it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
DESCRIPTION
fixing build errors
STAGING
https://deploy-preview-674--docs-compass.netlify.app/indexes/
JIRA
https://jira.mongodb.org/browse/DOCSP-43970
BUILD LOG
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?