Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43936-mongosh-multiple-connections #672

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Sep 30, 2024

DESCRIPTION

Adding MongoDB shell touchpoint

STAGING

https://deploy-preview-672--docs-compass.netlify.app/embedded-shell/#open-the-embedded-mongodb-shell

JIRA

https://jira.mongodb.org/browse/DOCSP-43936

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit 059379b
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/66fb01723202b200087ca2af
😎 Deploy Preview https://deploy-preview-672--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just leaving a small formatting suggestion which you can take or leave. Thanks @ltran-mdb2!

To open the embedded :binary:`mongosh`, click :guilabel:`>_` on the
right of your deployment name in the :guilabel:`Connections Sidebar` or
click :guilabel:`>_Open MongoDB Shell` in the top right of the
:guilabel:`Databases` tab.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Optional suggestion]

To make this a bit more scannable, we could consider making these bullets. As in:

To open the embedded :binary:`mongosh`, you can either:

- Click :guilabel:`>_` on the right of your deployment name in the :guilabel:`Connections Sidebar`.
- Click :guilabel:`>_Open MongoDB Shell` in the top right of the :guilabel:`Databases` tab. 

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched these lines to bullets! Thanks!

Comment on lines 27 to 28
- Click :guilabel:`>_Open MongoDB Shell` in the top right of the
:guilabel:`Databases` tab.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually click this button in any connection-specific tab, and the button has "shell" written in lowercase. Thanks Lauren!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants