Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-42973-compass-nested-components #671

Conversation

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit d39ace0
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/66f45283acc847000802ba17
😎 Deploy Preview https://deploy-preview-671--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mdb-ashley mdb-ashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good, Grace! I added some comments for your consideration.


You can use :v6.0:`AWS </core/queryable-encryption/fundamentals/kms-providers/#amazon-web-services-kms>`
to manage your keys.
AWS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, this isn't rendering. Take another look?

.. list-table::
:header-rows: 1
:widths: 30 30 70
GCP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also isn't rendering.


.. _azure-compass-encryption:

Azure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdb-ashley now it is actually ready for internal review!

Copy link
Collaborator

@mdb-ashley mdb-ashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a couple of comments. Nice work on this, Grace!

.. _local-kms:
.. step:: Click Connect.

KMS Provider Links
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KMS Provider Links
KMS Providers

- If the *Client Private Key* is protected with a password,
you must provide the password.

(Optional) Specify an EncryptedFieldsMap:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(Optional) Specify an EncryptedFieldsMap:
(Optional) Specify an ``EncryptedFieldsMap``:

(Optional) Specify an EncryptedFieldsMap:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add an optional client-side EncryptedFieldsMap for enhanced security.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add an optional client-side EncryptedFieldsMap for enhanced security.
Add an optional client-side ``EncryptedFieldsMap`` for enhanced security.

@sarah-olson-mongodb sarah-olson-mongodb merged commit d8a646c into mongodb:master Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants