-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-42077 Query History Autocomplete #663
DOCSP-42077 Query History Autocomplete #663
Conversation
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these helpful additions, @ajhuh-mdb! This one LGTM.
Thank you,
Joe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just 1 thing that would be good to add. Thanks Ali!
source/query/recent.txt
Outdated
through your most recent queries, you can use the :kbd:`↑` and :kbd:`↓` arrow | ||
keys. If a query is highlighted on the menu, it displays a pop-up panel that | ||
shows the filter, project, and sort stages of the query. To select a query from | ||
the autocomplete menu, press :kbd:`Enter` or click the query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A user can click Enter
or Tab
to select the highlighted autocomplete option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
Thanks for taking a look @betsybutton ! This should be ready for re-review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ali, LGTM!
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/compass/master/ 🪵 Logs |
DESCRIPTION
Adds section in 'View Recent Queries' page on query autocompletion.
STAGING
https://preview-mongodbajhuhmdb.gatsbyjs.io/compass/DOCSP-24077-query-history-autocompletion/query/recent/
JIRA
https://jira.mongodb.org/browse/DOCSP-42077
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=66ccc46f25dc1b90c70b955c
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?