Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-42077 Query History Autocomplete #663

Merged

Conversation

ajhuh-mdb
Copy link
Collaborator

DESCRIPTION

Adds section in 'View Recent Queries' page on query autocompletion.

STAGING

https://preview-mongodbajhuhmdb.gatsbyjs.io/compass/DOCSP-24077-query-history-autocompletion/query/recent/

JIRA

https://jira.mongodb.org/browse/DOCSP-42077

BUILD LOG

https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=66ccc46f25dc1b90c70b955c

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit 8230c0a
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/66def6876bdca10008d8abef
😎 Deploy Preview https://deploy-preview-663--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these helpful additions, @ajhuh-mdb! This one LGTM.

Thank you,
Joe

@ajhuh-mdb ajhuh-mdb changed the title DOCSP-24077 Query History Autocomplete DOCSP-42077 Query History Autocomplete Aug 26, 2024
Copy link

@betsybutton betsybutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just 1 thing that would be good to add. Thanks Ali!

through your most recent queries, you can use the :kbd:`↑` and :kbd:`↓` arrow
keys. If a query is highlighted on the menu, it displays a pop-up panel that
shows the filter, project, and sort stages of the query. To select a query from
the autocomplete menu, press :kbd:`Enter` or click the query.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user can click Enter or Tab to select the highlighted autocomplete option

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@ajhuh-mdb
Copy link
Collaborator Author

Thanks for taking a look @betsybutton ! This should be ready for re-review :)

Copy link

@betsybutton betsybutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ali, LGTM!

@ajhuh-mdb ajhuh-mdb merged commit d3203fc into mongodb:master Sep 9, 2024
5 checks passed
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants