DOCSP 37463 Updating connection window flow #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajhuh-mdb
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Thanks @ltran-mdb2 for these updates! Just a few comments before this is ready to go.
source/connect/advanced-connection-options/authentication-connection.txt
Show resolved
Hide resolved
|
Thank you for your feedback @ajhuh-mdb ! This should be ready for another review. |
|
LGTM ✅ |
ajhuh-mdb
approved these changes
Jul 18, 2024
lerouxb
reviewed
Jul 19, 2024
| @@ -25,6 +25,10 @@ Procedure | |||
| .. procedure:: | |||
| :style: normal | |||
|
|
|||
| .. step:: Open the :guilabel:`New Connection` window. | |||
There was a problem hiding this comment.
Are we referring to modal dialogs windows? Seems like that would be confusing given that window means something else already.
There was a problem hiding this comment.
I changed all mentions to use the word "modal"
lerouxb
reviewed
Jul 19, 2024
| .. step:: (Optional). Name your connection. | ||
|
|
||
| Use the name field to enter a name for your connection. If you do | ||
| not specify a name, Compass uses the cluster's hostname as the the |
lerouxb
reviewed
Jul 19, 2024
| .. step:: (Optional). Choose a color for your connection. | ||
|
|
||
| Use the color drop-down menu to select a label color for your | ||
| connection. When you activate a connection, the label color is the |
There was a problem hiding this comment.
Are we going with "activate a connection"? Isn't it just connect and disconnect?
There was a problem hiding this comment.
I used "activate" based on the "Active Connections" menu but changed to "connect"
|
Thanks for your feedback @lerouxb ! Could you take another look when you get a chance? |
lerouxb
approved these changes
Jul 19, 2024
sarah-olson-mongodb
merged commit 3c8c981
into
mongodb:multiple-connections
1 check passed
|
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/compass/multiple-connections/ 🪵 Logs |
sarah-olson-mongodb
pushed a commit
that referenced
this pull request
Aug 27, 2024
* DOCSP 37462 Updating Connect to MonogDB Compass page for multiple connections (#617) * DOCSP-37462 updating connect to MongoDB Compass page * DOCSP-37462 updating connect to MongoDB Compass page * DOCSP-37462 updating connect to MongoDB Compass page * DOCSP-37462 removing extra space * DOCSP 37458 - multiple connections on Compass Home (#616) * DOCSP-37458 multiple connections home screen update * DOCSP-37458 multiple connections home screen update * DOCSP-37458 copy edits * DOCSP-37458 typo * DOCSP-37458 adding database title * DOCSP-37458 adding database title * DOCSP 37463 Updating connection window flow (#647) * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 general connection tab * DOCSP-37463 copy edits * DOCSP-37463 copy edits * DOCSP-37463 tech edits * DOCSP-37463 tech edits * DOCSP-37461 Connections Sidebar Page (#646) * DOCSP-37461 creating interact with your connections page * DOCSP-37461 creating interact with your connections page * DOCSP-37461 creating interact with your connections page * DOCSP-37461 creating interact with your connections page * DOCSP-37461 creating interact with your connections page * DOCSP-37461 creating interact with your connections page * DOCSP-37461 Ali comments * DOCSP-37461 Ali comments * DOCSP-37461 Ali comments * Revert "DOCSP-37461 Ali comments" This reverts commit b992c3a. * Revert "DOCSP-37461 Ali comments" This reverts commit 11bb3c6. * DOCSP-37461 deleting extra page * DOCSP-37461 copy edits * DOCSP-37461 copy edits * DOCSP-37461 typo * DOCSP-37461 sidebar restructure * DOCSP-37461 sidebar restructure * DOCSP-37461 sidebar restructure * DOCSP-37461 sidebar restructure * DOCSP-37461 sidebar restructure * DOCSP-37461 tech edits * DOCSP-37461 tech edits * DOCSP-37461 move shell option * DOCSP 37460 Updating Compass Multiple Connections Screenshots (#658) * DOCSP-37460 updating Compass screenshots * DOCSP-37460 updating Compass screenshots * DOCSP-37460 ian edits * DOCSP-42696 update Favorite Connections and Performance page (#661) * DOCSP-42696 update Favorite Connections page * DOCSP-42696 update Favorite Connections page * DOCSP-42696 update Favorite Connections page * DOCSP-42696 update Favorite Connections page * DOCSP-42696 adding performance * DOCSP-42696 adding performance * DOCSP-42696 restructuring ToC * DOCSP-42696 restructuring ToC * DOCSP-38430 Julia comments * DOCSP-38430 Julia comments * DOCSP-38430 Julia comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Updating connection interaction flow with new connection window
STAGING
https://preview-mongodbltranmdb2.gatsbyjs.io/compass/DOCSP-37463/connect/#provide-your-connection-string
https://preview-mongodbltranmdb2.gatsbyjs.io/compass/DOCSP-37463/connect/advanced-connection-options/general-connection/
https://preview-mongodbltranmdb2.gatsbyjs.io/compass/DOCSP-37463/connect/advanced-connection-options/authentication-connection/
https://preview-mongodbltranmdb2.gatsbyjs.io/compass/DOCSP-37463/connect/advanced-connection-options/tls-ssl-connection/
https://preview-mongodbltranmdb2.gatsbyjs.io/compass/DOCSP-37463/connect/advanced-connection-options/ssh-connection/
https://preview-mongodbltranmdb2.gatsbyjs.io/compass/DOCSP-37463/connect/advanced-connection-options/in-use-encryption/
https://preview-mongodbltranmdb2.gatsbyjs.io/compass/DOCSP-37463/connect/advanced-connection-options/advanced-connection/
JIRA
https://jira.mongodb.org/browse/DOCSP-37463
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=6696c16e26eba795527a4065
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?