DOCSP-40542 Compass Quit Functionality Update #640
Conversation
There was a problem hiding this comment.
Thanks @ianf-mongodb! LGTM with a few items for consideration.
| Checking the ``Do not ask again`` checkbox on the quit dialog | ||
| disables this setting. |
There was a problem hiding this comment.
(structure)
To disable this setting, check "Do not ask again".
There was a problem hiding this comment.
This removes the reference to the quit dialog box which is a separate element than where the setting is stored. This is a supplemental way to turn off the setting option.
So it needs to be:
"You can also check the Do not ask again checkbox on the quit dialog to disable the setting."
| @@ -107,6 +107,15 @@ You can configure the following settings on the |compass| interface: | |||
| enabled. You cannot toggle this option on Linux. You can toggle this | |||
| setting only on Windows or macOS. | |||
|
|
|||
| * - Show Quit Confirmation Dialog | |||
| - General | |||
| - Toggle whether a confirmation dialog is shown when quitting Compass. | |||
There was a problem hiding this comment.
(term and active voice)
I'm a little concerned about toggle. I think we could get more specific. Also we want to stay away from "is shown". So maybe something like:
Specifies whether to display the confirmation dialog when you exit Compass.
|
@Anemy this is ready for review. |
Co-authored-by: Rhys <[email protected]>
|
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/compass/master/ 🪵 Logs |
DESCRIPTION
:kbd:role.STAGING
https://preview-mongodbianfmongodb.gatsbyjs.io/compass/DOCSP-40542/settings/settings-reference/#settings
https://preview-mongodbianfmongodb.gatsbyjs.io/compass/DOCSP-40542/keyboard-shortcuts/
JIRA
https://jira.mongodb.org/browse/DOCSP-40542
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=6684128efe162e50061300a9
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?