Support PHP 8.3 #760
Support PHP 8.3 #760
Conversation
|
We need phpspec/phpspec#1450 to be fixed before we can really support PHP8.3. I might merge it even if PHPSpec is not ready yet. |
|
Also need to get these docs fixed. |
|
I wish this project did not depend on PHPSpec. Every year it's the same blocker 😢 |
|
Yeah, I agree. That's why I said I would even merge it despite lack of phpspec support. I would not mind getting rid of it at all. If you see time to come up with a PR, I would very much welcome it. With rector it might be less work than we think. Although, moving to tests folder might conflict with our current phpunit tests. |
|
What if we drop the specs completely? Isn't it covered by unit tests already? |
|
I would only do such a thing if we would know, rather than think it does. |
|
I have increased the test coverage of the unit tests. Now every file is tested, and has a coverage of above 80%, with the far majority having a coverage of 90%+. Maybe we should indeed drop the phpsec. I am giving it another thought later this week, before really removing it. |
|
I think this is ready to go |
|
Wow, great that PHPSpec has been removed. This will make future maintenance and contributions easier! 🎉 |
|
We could also drop PHP 8.0, maybe in a separate PR. Security support for 8.0 will be dropped in a few days. If people want to use MoneyPHP with PHP 8.0 they can use <= ~4.2.0, while PHP 8.3 would require ^4.3.0. |
|
If a PHP version is EOL, we can drop it indeed. But please do it in a separate PR / release 😁 |
No description provided.