feat(Tipseen): New paddings for tipseen #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
approved these changes
Jul 22, 2024
| @@ -1,3 +1,4 @@ | |||
| .title { | |||
| padding-right: var(--spacing-medium); | |||
| padding-bottom: var(--spacing-xs);; | |||
There was a problem hiding this comment.
double semi-colon at the end
YossiSaadi
reviewed
Jul 22, 2024
Comment on lines
+6
to
+8
| &:not(:first-child) { | ||
| padding-top: 12px; | ||
| } |
There was a problem hiding this comment.
only one question, why did you changed it?
There was a problem hiding this comment.
It felt like a better location (since the mixin name related to the padding)
There was a problem hiding this comment.
It sound like the mixin is just very redundant, is it even exported from Vibe?
There was a problem hiding this comment.
I agree
It is not exported,do you think it will be best if I will just remove it?
There was a problem hiding this comment.
if for sure not exported, let's remove it, yes
if it takes time to check it so leave it as is and create a task for future check 💪🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/6947400555