Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add medium bold to header #2242

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Add medium bold to header #2242

merged 3 commits into from
Aug 1, 2024

Conversation

shaharzil
Copy link
Contributor

@shaharzil shaharzil requested a review from a team as a code owner July 17, 2024 16:45
@@ -12,5 +12,9 @@
.editableHeading {
width: 200px;
}

.editableHeading:first-child {
width: 125px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it gets really ugly with the addition of a fourth category

$font-h2-normal: 500 24px / 30px var(--title-font-family);
$font-h2-light: 300 24px / 30px var(--title-font-family);
$font-h3-bold: 600 18px / 24px var(--title-font-family);
$font-h3-bold: 700 18px / 24px var(--title-font-family);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a really minor change but are we ok with that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are :)

@shaharzil shaharzil requested a review from talkor August 1, 2024 09:51
@shaharzil shaharzil merged commit 12f7e4d into master Aug 1, 2024
10 checks passed
@shaharzil shaharzil deleted the add-medium-bold-to-header branch August 1, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants