fix(DatePicker): Keyboard Navigation #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaharzil
reviewed
Jul 23, 2024
| @@ -25,9 +25,9 @@ export interface YearPickerProps { | |||
|
|
|||
| const YearPicker = ({ selectedDate, isYearBlocked, changeCurrentDate, "data-testid": dateTestId }: YearPickerProps) => { | |||
| const selectedYear = selectedDate ? selectedDate.format(YEAR_FORMAT) : moment().format(YEAR_FORMAT); | |||
|
|
|||
| const currentYear = moment().format(YEAR_FORMAT); | |||
There was a problem hiding this comment.
Why did we needed to add this?
There was a problem hiding this comment.
Since the selected year is now the newly selected year I thought it would be confusing if the view of the years changes after each time the user changes a date.
|
|
||
| const renderMonthYearSelection = useCallback(() => { | ||
| return ( | ||
| <YearPicker | ||
| data-testid={dataTestId || getTestId(ComponentDefaultTestId.DATEPICKER_YEAR_SELECTION, id)} | ||
| selectedDate={date} | ||
| selectedDate={overrideDateForView || date} |
There was a problem hiding this comment.
Why are we changing the selected date?
There was a problem hiding this comment.
In order to fix the bug in the years select that it wasn't highlighting the newly selected year.
shaharzil
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/views/80492480/pulses/6958030426