feat(textField): Add option for tooltip on icon #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not-clickable-6965412634' into allow-icon-to-be-focusable-when-not-clickable-6965412634
YossiSaadi
reviewed
Jul 23, 2024
packages/core/src/components/TextField/__tests__/__snapshots__/TextField.snapshot.test.js.snap
Outdated
Show resolved
Hide resolved
packages/core/src/components/TextField/__tests__/__snapshots__/TextField.snapshot.test.js.snap
Outdated
Show resolved
Hide resolved
packages/core/src/components/TextField/__tests__/__snapshots__/TextField.snapshot.test.js.snap
Outdated
Show resolved
Hide resolved
…4' into Add-tooltip-for-icon-in-TextField-6965420722
YossiSaadi
reviewed
Jul 24, 2024
packages/core/src/components/TextField/__tests__/__snapshots__/TextField.snapshot.test.js.snap
Outdated
Show resolved
Hide resolved
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: To update Or with npm: |
YossiSaadi
approved these changes
Jul 24, 2024
Base automatically changed from
allow-icon-to-be-focusable-when-not-clickable-6965412634
to
master
July 24, 2024 12:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/views/80492480/pulses/6965420722
Added an option for displaying a tooltip on the icon, regardless if it is clickable or not.