fix(icon): Allow icon to be focusable when not clickable #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not-clickable-6965412634' into allow-icon-to-be-focusable-when-not-clickable-6965412634
YossiSaadi
approved these changes
Jul 23, 2024
Comment on lines
-64
to
-74
| const iconLabel = useMemo(() => { | ||
| if (type === AttentionBoxType.DANGER) { | ||
| return "alert"; | ||
| } | ||
|
|
||
| if (type === AttentionBoxType.SUCCESS) { | ||
| return "success"; | ||
| } | ||
|
|
||
| return "attention"; | ||
| }, [type]); |
There was a problem hiding this comment.
We said those are redundant anyway, right?
There was a problem hiding this comment.
Yes, the icon is for decoration purpose only
Comment on lines
11
to
12
| // TODO remove in next major | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
maybe also add this in the type declaration as you did in other places, as it is easy to remove it from here and forget to remove from declaration. so even only there is enough instead of here, as this way it would show an error, but not the other way around
| <Tooltip | ||
| content={infoContent} | ||
| referenceWrapperClassName={styles.infoTooltip} | ||
| addKeyboardHideShowTriggersByDefault |
There was a problem hiding this comment.
btw, is this has a task to become default true at next major? just wondering 👀
There was a problem hiding this comment.
I didn't see one, so added it
| @@ -66,6 +66,7 @@ export interface TextFieldProps extends VibeComponentProps { | |||
| searchResultsContainerId?: string; | |||
| activeDescendant?: string; | |||
| /** Icon names labels for a11y */ | |||
| /// TODO Remove layout in next major | |||
| @@ -69,7 +69,7 @@ export const States: Story = { | |||
| <TextField placeholder="With icon" iconName={Email} size={TextField.sizes.MEDIUM} /> | |||
| <TextField | |||
| placeholder="With clickable icon" | |||
| iconName={Email} | |||
| iconName={Duplicate} | |||
There was a problem hiding this comment.
makes more sense for the sake of the example, good job 👏🏼
rivka-ungar
deleted the
allow-icon-to-be-focusable-when-not-clickable-6965412634
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/views/80492480/pulses/6965412634