fix(Button): dispatch onclick event on edge #1862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
reviewed
Jan 2, 2024
Comment on lines
+77
to
+79
| --button-scale-factor: 0.95; | ||
| transform: scale(var(--button-scale-factor)) translate3d(0, 0, 0); | ||
| margin: calc(1% * (1 - var(--button-scale-factor))); |
There was a problem hiding this comment.
This makes other elements on the screen to be shifted when the button is pressed:
Screen.Recording.2024-01-02.at.11.35.41.mp4
There was a problem hiding this comment.
I will check the issue again.
Do you have a visual testing tool, such as Applitool or Percy?
There was a problem hiding this comment.
There are two potential solutions:
- adding a DOM element as a wrapper
- replace the scale reduction with box shadow
I don't like both changes because they change the original design or impact performance.
There was a problem hiding this comment.
I completely agree, it's a tricky one 💭
talkor
reviewed
Jan 2, 2024
| @@ -9,7 +9,7 @@ function renderComponent(props) { | |||
| return render(<Button {...props}>{text}</Button>); | |||
| } | |||
|
|
|||
| describe("<Buttoon />", () => { | |||
| describe("<Button />", () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The button doesn't dispatch on click event when clicking on the button's edge.
Issue #1766
Symptoms
Clicking on the Button component causes the edges of the button to move inward before the click event can be fully registered.
Solution
The added margin calculation compensates for the button's size reduction due to scaling.