Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python linter error - Part 2 #323

Merged
merged 4 commits into from
Nov 20, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# License for the specific language governing permissions and limitations
# under the License.


def main():
pass

Expand Down
10 changes: 4 additions & 6 deletions ci.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,21 @@
#

from __future__ import print_function

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this empty line

import datetime
from google.cloud import storage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from ... import ... should be separated from import ...

from google.oauth2 import service_account
import gzip
import json
import os
import re
import shutil
import signal
import six
import subprocess
import sys
import time
import yaml

import six
from google.oauth2 import service_account
from google.cloud import storage


TAG_REGEX = re.compile(r'^!(\w+)(?:\s+([\w-]+))?$')

Expand Down Expand Up @@ -772,7 +770,7 @@ def kill(signal, frame):
if time_delta == 1500:
print ('Tempest-tests timed out at 25 min')
raise TempestTestFailedException()
if time_delta % 30 == 0:
if time_delta % 30 == 0: # noqa: S001
print ('Still running tempest-tests')
time_delta += 1
time.sleep(1)
Expand Down