Add linters to Travis: Python #264
Conversation
|
I think we should configure it with same/similar configuration like in openstack |
|
I think that most standard/popular way of having configuration for Python linters would be Some more info for consideration with pylint: |
…ters-python # Conflicts: # .travis.yml
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
.travis.yml
Outdated
| script: flake8 | ||
| - stage: linting-pylint | ||
| script: pylint --rcfile=setup.cfg * | ||
| - stage: lint-shellcheck |
There was a problem hiding this comment.
Remove duplicated shellcheck stage
setup.cfg
Outdated
| ignore = D203,H201,H302,H405 | ||
| # H106: Don’t put vim configuration in source files | ||
| # H203: Use assertIs(Not)None to check for None | ||
| enable-extensions = H106,H203 |
There was a problem hiding this comment.
All Hxxx are comming from OpenStack hacking https://docs.openstack.org/hacking/latest/ so it also need to be installed
setup.cfg
Outdated
| builtins = _ | ||
|
|
||
| [pylint] | ||
| disable = C0103,C0111,F0010 |
There was a problem hiding this comment.
Put comments with description what are you disabling (like in 2-5 lines)
Splitting #191 for manageability