Fix some linter warnings, part 2 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Max 5 containers at the same time reached. |
matrixik
force-pushed
the
fix_lint3
branch
2 times, most recently
from
ed7d5d0
to
8af4d27
Compare
kornicameister
previously approved these changes
Sep 18, 2017
|
They will need to be rebuilt to pull in the new changes, but I don't know how urgent pushing new images out for most of this is given it's mostly code quality vs functional changes - if nothing else they'll get picked up the next time we release. Feel free to bump versions and go crazy with |
timothyb89
previously approved these changes
Sep 18, 2017
kafka-init/wait-for.sh
Outdated
| @@ -54,9 +54,9 @@ wait_for_wrapper() | |||
| { | |||
| # In order to support SIGINT during timeout: http://unix.stackexchange.com/a/57692 | |||
| if [[ $QUIET -eq 1 ]]; then | |||
| timeout $BUSYTIMEFLAG $TIMEOUT $0 --quiet --child --host=$HOST --port=$PORT --timeout=$TIMEOUT & | |||
| timeout "$BUSYTIMEFLAG" "$TIMEOUT" $0 --quiet" --child --host="$HOST" --port="$PORT" --timeout="$TIMEOUT" & | |||
There was a problem hiding this comment.
Erroneous double quote after --quiet
matrixik
dismissed stale reviews from timothyb89 and kornicameister
via
4154d91
|
I believe this is ready to merge by someone with appropriate rights :) @kornicameister @matrixik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #191