Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed build.sh scripts #161

Merged
merged 3 commits into from
Aug 21, 2017
Merged

Removed build.sh scripts #161

merged 3 commits into from
Aug 21, 2017

Conversation

kornicameister
Copy link
Contributor

build.sh are no longer used. Local builds
can be executed with plain docker build
command therefore those scripts are not required.

Closes #124

@kornicameister kornicameister self-assigned this Aug 16, 2017
@kornicameister
Copy link
Contributor Author

@timothyb89 quess the reason it terminated....is....that the log output was too long :/. Anyway, I don't see this as the blocker, those scripts are, as far as I know, are pretty much redundant.

@timothyb89
Copy link
Member

Yikes, I guess dbuild console output can get pretty spammy when lots of images are built at once. Those
build scripts are definitely not used in CI. Rebuilding the containers isn't even necessary in this case, I believe we can just skip travis for this commit as a workaround with [skip ci].

Also filed monasca/dbuild#3

timothyb89
timothyb89 previously requested changes Aug 16, 2017
View reviewed changes
monasca-python/build.sh Outdated
@@ -1,122 +0,0 @@
#!/bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait a sec. Maybe this shouldn't be removed? 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, 🥇 for me.
I ran a find command and just removed everything that popped out...ah :D

@kornicameister
Copy link
Contributor Author

kornicameister commented Aug 17, 2017 •
edited
Loading

Ok, I had to --force push, but I guess it is fine now.

@kornicameister kornicameister dismissed timothyb89’s stale review August 18, 2017 04:01

The changes requested had to be forced push

@timothyb89 timothyb89 merged commit 05aae43 into monasca:master Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyb89 timothyb89 timothyb89 approved these changes

Assignees

@kornicameister kornicameister

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kornicameister @timothyb89