One Python to rule them all #143
Conversation
kornicameister
changed the title
monasca-agent-base/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM alpine:3.5 | |||
| FROM monasca/python:2 | |||
There was a problem hiding this comment.
Maybe it would be better to use the full image tag here (with date and timestamps)? That way we'll never need to worry about local caches using an old python-base with a new upstream git. The pr-bot will (soon™) handle updates to the base image automatically.
There was a problem hiding this comment.
Sure thing, will look into that.
There was a problem hiding this comment.
#142 should enter first to refer to correct tags.
|
Replicated the travis run locally and everything has been built ok (It couldn't launch the services, but I had devstack launched in the same time, so ports were already taken), so I guess we need to have #142 reviewed & merged |
|
Huh, that's odd...according to the build of #142 , the version of monasca/python ought to be @timothyb89 shouldn't updated image (with newer TS) be uploaded to the hub ? |
|
Ah, yeah, looks like I forgot to tag the merge commit to have it push the new image. It built (as it always will) but didn't 'release' the new image. I'll make sure it pushes in #148 FWIW I have some improvements to this workflow in my backlog... soon, I hope. |
kornicameister
changed the title
monasca-alarms/Dockerfile
Outdated
| pip install python-monascaclient && \ | ||
| rm -rf /root/.cache/pip && \ | ||
| RUN apk add --no-cache py2-netaddr py2-yaml py2-jinja2 && \ | ||
| apk add --no-cache --virtual build-dep && \ | ||
| apk del build-dep |
There was a problem hiding this comment.
Hmm, this seems a bit odd. If build-dep is empty we can probably skip adding/deleting it entirely.
|
@timothyb89 @mhoppal friendly ping ;) |
|
Hmm, so a few issues I ran into:
Other than these issues I think it's good to go! |
|
I think monasca-persister issue is related to recently added oslo-config-generator. That change featured also changing some of the properties types to to the more proper one, let's put it this way. It basically means that option that represented ip address or port number were declared as, respectively, string and integer where it should actually be About that monasca-agent. That is a bit surprising as I didn't actually change anything about the bit of installation ;/. At least I thought so :D. I wil look into it. |
|
@timothyb89 I am not really sure about the agent's paths. I just launched the ci.py locally replicating the travis and for me it goes like: $ docker run -it monasca/agent-collector:ci-cd sh -c "echo \"collector at: \" \$(command -v monasca-collector) ; echo \"forwarder at:\" \$(command -v monasca-forwarder)"
collector at: /usr/bin/monasca-collector
forwarder at: /usr/bin/monasca-forwardercan you 2-check that ? I will revert the commit in the meantime, because I think that is what messes up the CI. |
|
@timothyb89 can you show me some example of monasca-persister failing ? Seems ok enough, it starts properly in CI, otherwise no metrics wouldn't be saved and tempests would fail. |
|
Hmm interesting, I wonder if it's a python 2 vs 3 thing. I'll look into it a bit more. |
|
the reason it failed now is because monasca-api cannot connect to mysql database ? was something changed recently ? edit: guess that was a random error after all. Running travis once again and error is gone. |
| aliases: | ||
| - :latest | ||
| - tag: 1.1.1 |
|
Hmm, I'm still seeing the agent failing locally, either I have some outdated images that aren't getting rebuilt or the Is the change to the persister going to require any patches upstream? |
|
Alright, I've purged my docker cache and rebuilt everything manually. I'm still seeing the persister and agent containers crash. The agents fail with: The persister fails with: I believe building via ci.py is always going to generate incorrect results. The CI script isn't smart enough to patch the correct image into the |
|
Ok, getting back to work ;-). Holiday's over ;-( |
Use monasca/python for monasca-agent
In monasca/alarms, python-monascaclient is being used. It only makes sense to resuse that image and benefit from any updates that are made to monasca/client and/or monasca/python
Use version of monasca/agent-base inside build.yml for both monasca-agent-forwarder and monasca-agent-collector.
Updated versions of base image for: * monasca-agent-collector * monasca-agent-forwarder
|
Ahhh...I think I need to split it over into several PRs because of the recently introduced limit in the travis...totally forgot about that. There's a lot more images changes than just 5. |
|
Let's close it down and split the PR into PR per image manner. |
|
Yup, thanks for splitting it up! |
Rewrite all the images to leverage newly added monasca/python image.