-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #65
Conversation
…ets and doc files (adobecom#2416) * MWPW-147601: sending ML field text to Analytics * MWPW-147989 and MWPW-151786: handle localized path for quiz spreadsheets and doc files * update code according to feedbacks
Add news.adobe.com as trusted federal origin
* Update section-metadata.css * fix indentation
…g has been loaded (adobecom#2427) [MWPW-151474] Ensure navigation is displayed after everything has been loaded
* consume new ost * upd to latest * test ost changes * support annual merch link * MWPW-146963: calculate annual of ABM * fix review comment * include revert of breaking change
* mwpw-151992: allow to always merge zero impact PRs * Label zero impact PRs in slack & PR description
* mwpw-150087: bump action dependencies * bump codeql * bump paths filter * Update codecov * Remove fixed versions
…adobecom#2446) Fix gnav placeholders
* Adding feature to hide breadcrumbs when dynamic-nav is active * Moving logic for 'has-breadcrumbs' into utils.js to prevent CLS * Removing extraneous code from gnav since utils modifies breadcrumb functionality * Adding feature to hide breadcrumbs when dynamic-nav is active * Moving logic for 'has-breadcrumbs' into utils.js to prevent CLS * Removing extraneous code from gnav since utils modifies breadcrumb functionality
…sidekick (adobecom#2413) * Actually fixing original bug in sidekick * Increasing code coverage * Fixing missing export --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
…fault and override with mep= (adobecom#2439) * replace overridePersonalizationVariant function * Fix chaining * Move parseMepParam * add additional optional chaining operator Co-authored-by: Vivian A Goodrich <[email protected]> * MWPW-151561 [MILO][MEP] MEP button does not appear if Target is on but there are no pzn manifests (adobecom#2441) * calculate preview in utils * update personalization to not recalculate * replace overridePersonalizationVariant function * Fix chaining * Move parseMepParam * add additional optional chaining operator Co-authored-by: Vivian A Goodrich <[email protected]> * MWPW-151561 [MILO][MEP] MEP button does not appear if Target is on but there are no pzn manifests (adobecom#2441) * calculate preview in utils * update personalization to not recalculate * Revert "MWPW-151561 [MILO][MEP] MEP button does not appear if Target is on but there are no pzn manifests (adobecom#2441)" This reverts commit eca39b0. --------- Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: vgoodric <[email protected]>
* Graybox bug fixes * Support both gb-no-click and no-click * no-click and gnav fixes * device preview fixes * Fix and add tests
… is selected when it should not be (adobecom#2469) add space
* Increase 404 rum tracking to 10% * Address feedback * Address feedback * Increase the general tracking weight for 404 pages * Increase tracking for 404s * Improve ID creation * Use getMetadata
…tion.js (adobecom#2454) * replace overridePersonalizationVariant function * Fix chaining * Move parseMepParam * add additional optional chaining operator Co-authored-by: Vivian A Goodrich <[email protected]> * Refactor personalization.js * Remove comment * Add back in deleted variants --------- Co-authored-by: Vivian A Goodrich <[email protected]>
* [MWPW-151673] Library templates Add templates to sidekick library Resolves: MWPW-151673 * Fixing library unit tests --------- Co-authored-by: Ryan Clayton <[email protected]>
* foe locui block that displays the message to re-run * update message
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Skipped merging 55: "fooPR" due to failing checks |
Skipped merging 55: "fooPR" due to failing chec2ks |
Skipped merging 55: "fooPR" due to failing checks |
Skipped merging 55: "fooPR" due to failing chec2ks |
…dobecom#2229) * MWPW-146856: Left/right padding missing on segment cards on mobile Fixes Left/right padding missing on segment cards on mobile viewport. Tacocat PR: https://git.corp.adobe.com/wcms/tacocat.js/pull/584 Resolves: MWPW-146856 Test URLs: Before: https://main--milo--adobecom.hlx.page/?martech=off After: https://MWPW-146856--milo--adobecom.hlx.page/?martech=off * Update merch-card.js * Update merch-card.js * Update merch-card.js * updated dependency * Update merch-card.js
…ecom#2403) * modified georouting and pep so that pep only appears if a) GRM is not shown or b) GRM is dismissed * Unit test for GRM/PEP interaction * changed grmActive to geoRoutinActive * Fixed unit test for grm/pep interaction * removed unused imports * Cleaned up the implementation * Changed from polling to listening for an event * removed an unnecessary line * Modified unit test * Changed the implementation to use polling for any modal * Changed pep loading logic to poll for modals only after the close modal dialog comes through
* MWPW-147206 making promo schedule geo aware mostly to allow authors enabling promos in separate smaller files, schedule directive has now a locales setting to narrow its activation to those countries promoEnabled parameter passed to getPromoManifests in promo utils is now an object that has entries for each region promo name that are fetched at very early time (no geo resolution), default being kept for backward compatibility reasons with key `manifestnames`. getPromoManifests then resolves current locale and serves merged manifests between regional specific ones (if locale matches), and 'global' ones. * lint & ut fix * MWPW-147206 removing non matching manifests * lint fix * review fixes * MWPW-147206 rares changes
…com#2461) * Removing data layer descriptions from fields * removing console.log
MWPW-xxxx - quiz option contrast fixes * adjusts the blue text color of selected option cards so they have enough accessible color contrast Resolves: [MWPW-147759](https://jira.corp.adobe.com/browse/MWPW-147759) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off
…adobecom#2743) added z-index to sp-action-menu
* MWPW-156262 use standard tab browsing in collection - set specific card keydown handler a property of a merch-card, true by default, - in case of contained in a collection, above property is set to false, and tabindex is added in same order than collection * MWPW-156262 removing arrow browsing altogether * MWPW-156262 remove key unit test, - no more custom logic to test, - removing window.width based test skips that was avoiding collection tests * rebuild deps --------- Co-authored-by: Mariia Lukianets <[email protected]>
* test for perf tiger teams * MWPW-155687 * removing old
Revert "MWPW-151936 Aside Tiger Team Enhancements (adobecom#2644)" This reverts commit dfaf39f.
* Removal of merch-card-all dep * improved dep imports * Update mas.js * Update mas.js * removed sequential imports * pr feedback * fixes
adobecom#2703) * changes in utils * changes in utils view port * changes in view-port sizes * unit test cases * viewport for desktop * viewport for desktop * shifting the logic to decorate.js * lint error * lint error * unit tests * unit tests * unit tests * unit tests * unit tests * unit tests --------- Co-authored-by: Suhani <[email protected]> Co-authored-by: Suhani <[email protected]>
…se (adobecom#2751) * Prevent link breaks before 'ー U+2013', '〜 U+301C' * Refactor CSS for Japanese line-break
…2717) * MWPW-155057: [Merch cards] Add ability for authors to add "starting at" Preview: https://main--cc--adobecom.hlx.page/drafts/axel/stories/mwpw-155057-starting-at?milolibs=MWPW-155057--milo--adobecom * improved impl * unit tests * Update merch-card.js * Update merch-card.test.js * Update segment-card.html * unit test * Update merch-card.js * Update merch-card.js * Update merch-card.test.js * Update merch-card.js * Update merch-card.js * Update merch-card.js * Update merch-card.js * Update merch-card.js * Update merch-card.js * unit test and pr feedback * conflicts resolved
* MWPW-151936 Aside Tiger Team Enhancements * fix standard tests * update tests * simplify icon area * set approved desktop column spans * css updates based on feedback * account for notifications --------- Co-authored-by: Megan Thomas <[email protected]>
…#2668) * added payment-details slot and changed badge width * fixed duplicated callout content * fixed eslint * added libs/deps/mas to paths-ignore in codeql * replaced payment-details slot
* changed the swc version to 0.46.0 * added polyfills import * corrected import * corrected import * added warning about polyfills in readme * fixed typos and changed imports * corrected import * brought back the loadScript * correction for the readme
* [MWPW-152305][MWPW-152339] Table background and checkmark treatment * MWPW-151826 - Table header and cell alignment (adobecom#2516) * header buttons vertical alignment matches across all headers * content cell horizontal alignment match what is set in headers defaulting to center * header style updates, including: color, font-size, etc. Resolves: [MWPW-151826](https://jira.corp.adobe.com/browse/MWPW-151826) Resolves: [MWPW-152313](https://jira.corp.adobe.com/browse/MWPW-152313) * [MWPW-153727] Remove extra border radius from table highlight (adobecom#2537) * [MWPW-153881] Table section not initially expanding on mobile (adobecom#2539) * [MWPW-153848][MWPW-153860] Table highlight, sticky, radius improvements (adobecom#2562) * [MWPW-153848][MWPW-153860] Table highlight, sticky, radius improvements * Avoid table exceeding viewport * MWPW-152336 - Table tooltip fixes (adobecom#2623) * MWPW-152336 - Table tooltip fixes * force tooltip positioning for row-title in mobile and rtl scenarios so they are always fully visible Resolves: [MWPW-152336](https://jira.corp.adobe.com/browse/MWPW-152336) * Update libs/blocks/table/table.css Co-authored-by: Rares Munteanu <[email protected]> * Update libs/blocks/table/table.css Co-authored-by: Rares Munteanu <[email protected]> * Update libs/blocks/table/table.css Co-authored-by: Rares Munteanu <[email protected]> * PR feedback to reduce verbose selectors --------- Co-authored-by: Rares Munteanu <[email protected]> * MWPW-153609 - Unit test fixes for table * Set hovering test to it targets an element that has height * Adjusted placement of the fix for MWPW-153881 to ensure that filters are added when it is called Resolves: [MWPW-153609](https://jira.corp.adobe.com/browse/MWPW-153609) * [MWPW-153267] Expand table to parent grid size (adobecom#2637) * [MWPW-153894] Addressing overflowing table content on mobile (adobecom#2672) * [MWPW-156638] Table row header items wrap (adobecom#2747) * [MWPW-156925] Table - design parity tweaks after Consonant feedback (adobecom#2760) --------- Co-authored-by: Cody Lloyd <[email protected]> Co-authored-by: Cody Lloyd <[email protected]>
… out (adobecom#2754) * MWPW-156898 [MEP] Add setting to use XLG segments in MEP while logged out * add 2 segments * unit test * unit test update
…m#2777) Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux) (adobecom#2767)" This reverts commit 88cb101.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
https://github.com/mokimo/milo/blob/d90dcc060835ab1b59b0cb4e96dbbc45a69f1d4f/libs/deps/mas/mas.js
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
const branch = new URLSearchParams(window.location.search).get('navbranch'); | ||
const miloLibs = branch ? `https://${branch}--milo--adobecom.hlx.page` : customLib || envMap[env]; | ||
if (!header && !footer) { | ||
console.error('Global navigation Error: header and footer configurations are missing.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/blocks/footer/footer.js
Line 349 in d90dcc0
console.log(`Could not create footer: ${error}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/blocks/footer/footer.js
Line 359 in d90dcc0
console.log('Could not create footer.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Hook useEffect has missing dependencies: 'lsKey' and 'panelsData'. Either include them or remove the dependency array.
}, [state]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React Hook useEffect has missing dependencies: 'blockClass' and 'getUrl'. Either include them or remove the dependency array.
}, []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: