Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to read property files located on the project classpath #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Stratehm
Copy link

Hi,

Here is a patch that adds a parameter to the plugin which allows to read property files from the dependencies of the built project.

The parameter is and defaults to false. If true, when a classpath URL resource is not found on the plugin classpath, the plugin will look for the resource on the project classpath.

@Stratehm
Copy link
Author

The openjdk6 check has failed since maven 3.5.0 is used to run it and java6 is no more supported by maven 3.5.0. Maybe the checks should be updated.

@jeffjensen
Copy link

I have wanted this feature for quite awhile and happy to see a PR that might work. Are any committers interested in working this one through?

@olamy
Copy link
Member

olamy commented Apr 6, 2020

I fixed travis file in master.
But your changes doesn;t have any tests. Can you please add one test?

@jeffjensen
Copy link

@Stratehm Hi, we have @olamy 's help with this at the moment, so wondering if you plan to soon add tests per his request and finalize this PR for merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants