added async support for exec:java #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koh-osug
force-pushed
the
java_async_support
branch
7 times, most recently
from
ddddc3c to
f8540ad
Compare
koh-osug
force-pushed
the
java_async_support
branch
from
f8540ad to
a337e76
Compare
|
What's stopping this from being merged? Maven exec takes the most time out of all goals in my build. Async would help tremendously. |
|
@michaelkrasa I guess what this stops from being merged or consider is that there are merge conflicts. I created a new PR for another existing PR with merge conflicts and that got then merged. so my suggestion is you do the same for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the problem of a server started with
exec:javablocking the further execution of Maven after thepre-integrationphase. The current plugin seems to offer no suitable way of executing a Java main class and let the execution continue while Maven can continue.This patch supports an
asyncoption together with a flexibleasyncStartCheckoption to be able to provide a custom script evaluating if the started Java class is ready. It is using the JavaScriptEngine for this evaluation supporting a wide range of script languages. I added a test using Groovy asproject16. I had to update the Groovy version of some plugins, the used version was very old.