#42: init implementation for yajsw #99
Conversation
|
@khmarbaise Do you have some hints for me how to reproduce the error from appveyor on a Linux system? |
| add("commons/commons-cli-1.4.jar"); | ||
| add("commons/commons-collections-3.2.2.jar"); | ||
| add("commons/commons-configuration2-2.3.jar"); | ||
| add("commons/commons-io-2.6.jar"); | ||
| add("commons/commons-lang3-3.8.1.jar"); | ||
| add("commons/commons-lang-2.6.jar"); | ||
| add("commons/commons-logging-1.1.jar"); | ||
| add("commons/commons-text-1.6.jar"); | ||
| add("commons/commons-vfs2-2.2.jar"); | ||
| add("jna/jna-5.3.1.jar"); | ||
| add("jna/jna-platform-5.3.1.jar"); | ||
| add("netty/netty-all-4.1.36.Final.jar"); | ||
| add("yajsw/ahessian.jar"); | ||
| } | ||
| }; | ||
|
|
||
| private static List<String> EXTENDED_LIBS = new ArrayList<String>() | ||
| { | ||
| { | ||
| add("velocity/velocity-1.7.jar"); | ||
| add("yajsw/hessian4.jar"); | ||
| add("groovy/groovy-2.5.7.jar"); | ||
| add("groovy/groovy-patch.jar"); |
There was a problem hiding this comment.
Do all these libraries have to have hardocded versions?
There was a problem hiding this comment.
Unfortunately, yes, because the version number is part of their name in the path. These libs are part of the YAJSW jar, that I downloaded before. YAJSW needs these libs for working correctly. See also my comment in the issue about the structure of YAJSW
There was a problem hiding this comment.
I get what you're saying, but each time there is an upgrade of the yajsw library, these lines (here and below) will have to be manually updated. Would it be possible to implement a cleaner way of doing this? For example, you can scan the directories for these jar files by a pattern and resolve the paths this way. I know it's a bit of extra work, but it will save a lot of work in the future when there's upgrades (and you know how error prone these manual "touches" tend to be)...
There was a problem hiding this comment.
I completely with you. Maintenance will be very hard with this solution. I would spend more time for a better solution when one of maintainers give feedback whether I run in the right direction with this PR.
IMHO the best solution would be when YAJSW would provide a normal Maven artifact in Maven central.
There was a problem hiding this comment.
IMHO the best solution would be when YAJSW would provide a normal Maven artifact in Maven central.
Do they have an issue open for this that would could link to, (or make some noise)?
There was a problem hiding this comment.
Any feedback on this pull request?
There was a problem hiding this comment.
IMHO the best solution would be when YAJSW would provide a normal Maven artifact in Maven central.
Do they have an issue open for this that would could link to, (or make some noise)?
It exists an elder ticket, but it doesn't address our problem.
@carlspring could you open a ticket and link it in our original issue?
There was a problem hiding this comment.
Not sure what you mean. Perhaps it would be easier/clearer for you to do it?
- refactoring yajsw lib name to a property variable
...org/codehaus/mojo/appassembler/daemon/yajsw/YetAnotherJavaServiceWrapperDaemonGenerator.java
Outdated
Show resolved
Hide resolved
...org/codehaus/mojo/appassembler/daemon/yajsw/YetAnotherJavaServiceWrapperDaemonGenerator.java
Outdated
Show resolved
Hide resolved
- cosmetic issue
first draft