Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added greeting bot #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added greeting bot #72

wants to merge 1 commit into from

Conversation

Sukriti-sood
Copy link
Contributor

Fixes #70

@HarshCasper
Copy link
Member

Hi @Sukriti-sood

Can you please fix the DCO? Just run the following commands:

git commit --amend --no-edit --signoff
git push --force-with-lease origin issue-forms

@Sukriti-sood
added greeting bot
29e9be9 
Signed-off-by: Sukriti-sood <[email protected]>
@Sukriti-sood
Copy link
Contributor Author

@HarshCasper done

@shubhamkarande13
Copy link
Member

@HarshCasper Can we merge this PR?

HarshCasper
HarshCasper requested changes Sep 26, 2021
View reviewed changes
Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sukriti-sood

We already have a config,yml that does the exact the same thing here: https://github.com/moja-global/moja_global_docs/blob/master/.github/config.yml

How does this improve our processes?

@Sukriti-sood
Copy link
Contributor Author

Hi @Sukriti-sood

We already have a config,yml that does the exact the same thing here: https://github.com/moja-global/moja_global_docs/blob/master/.github/config.yml

How does this improve our processes?

Not much , only the advantage is it will comment on every merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshCasper HarshCasper HarshCasper requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Greeting Bot
3 participants
@Sukriti-sood @HarshCasper @shubhamkarande13