Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README.md #121

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

rahulsh18
Copy link

@rahulsh18 rahulsh18 commented Aug 8, 2022

fixed the last section and made some punctuation changes. fixes issue #120 @HarshCasper
Signed-off-by: Rahul Sharma [email protected]

@padmajabhol padmajabhol self-requested a review August 10, 2022 07:58
Copy link
Member

@padmajabhol padmajabhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
Can you please sign the DCO?

@rahulsh18
Copy link
Author

Thanks a lot! Can you please sign the DCO?

added the sign off in the commit message above, is that enough?

@padmajabhol
Copy link
Member

Thanks a lot! Can you please sign the DCO?

added the sign off in the commit message above, is that enough?

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin patch-1

This should do.

fixed the last section and made some punctuation changes

Signed-off-by: rahulsh18 <[email protected]>
@rahulsh18
Copy link
Author

done @padmajabhol

Copy link
Member

@padmajabhol padmajabhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants