Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return message #210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Janengethe
Copy link

Pull Request Template

Description

While working on the GCBM Demo for the route POST /gcbm/title I discovered that the return message did not include the title of the simulation one is working on. So I included the f function for printing out the return message correctly.
Another thing, when one is testing the GCBM locally, with the instructions on the README.md file, there was a confusion on the terminals that you are supposed to be working with. So I edited this the right terminal for the docker container to be running on, and the terminal to test using curl command.

Fixes # (209)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tried testing using a simulation with the title "run4 as shown below:

Additional Context (Please include any Screenshots/gifs if relevant)

Alt text
Alt text
Alt text

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@Janengethe Janengethe changed the title Myfeature fix: Return message Nov 4, 2022
@khanjasir90
Copy link
Contributor

@Janengethe everything looks good to me :) but can u add screen shots of the working api response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants