Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
Called
MODx.ux.Ace.replaceComponent()
which gives MODX tag and syntax highlighting.The only oddity is that when saving, 2 values are given in value, because
MODx.ux.Ace.replaceComponent()
seems to create a new editor but not remove the old one. And I had to add$value = $value[1];
to fix it. Maybe @Mark-H can give a better fix.Before:
After:
Related issue(s)/PR(s)
N/A