Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fiber] Make fibers a bit more useable #1172

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

salkinium
Copy link
Member

@salkinium salkinium commented Jun 26, 2024

The yak is not entirely shaved yet.

  • Since the modm::this_fiber::yield() function is used so often it generates a non-inlined function anyways, so it would be nice to not have to deal with recursive include issues when including only <modm/processing/fiber/functions.hpp>.
  • Would be nice to have a small polyfill library for when fibers are not implemented. For example, the timers could use a wait() method that yields the fiber until the timer has expired. This should block when fibers are not implemented.

The fiber functions were written explicitly to only depend on the clock.
@salkinium salkinium force-pushed the fix/fiber_includes branch 3 times, most recently from 1959fa3 to 9dd71d9 Compare July 7, 2024 22:20
@salkinium salkinium marked this pull request as ready for review July 9, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

std::scoped_lock not declared in my environment (Fedora 14.1.0-1.fc40)
1 participant