-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic flatpak support #69
base: main
Are you sure you want to change the base?
Conversation
Adds working flatpak manifest based on github releases
A very good start, but how do we even build this? A CI step to generate some flatpak file would be great. |
As per the official flatpak documentation (https://docs.flatpak.org/en/latest/first-build.html), building it is as simple as:
|
I suppose we could use this action to build it using the CI: |
Just added a basic github action to build the flatpak too |
the CI needs to trigger for regular pushes and PRs, not just on release |
Currently the flatpak manifest depends upon releases, so there is no point in running the flatpak github action on regular pushes and PRs yet. After supporting build from latest sources then we can change the flatpak action to run on every push and PR. |
sure but we need to test if it even works first, and the point is to not have it use release binaries anyhow. |
Yeah, the whole point of this PR is to provide a basis for flatpak support, and make a flatpak build that can be published to flathub. As a second step we can augment this even more and modify the flatpak manifest to build from sources and not from releases, and finally merge the flatpak action as part of the build workflow/process to have flatpak binaries on releases too, along with every PR/commit. |
sure but I wish to test if the CI action works before merging, and that is not possible to do if the CI file requires a new release to be made just to test it... it is fine to let the CI run more often than needed, but the other way around is not. |
Changed flatpak workflow trigger event to |
Resulting flatpak now also exports the correct icon and desktop file |
Added the required metainfo file that is needed for publishing in relevant hubs/stores like flathub also, the app should be ready for publishing |
Adds working flatpak manifest based on github releases