buildkitd: configure telemetry providers with the global handlers #4957
Conversation
The global handlers are used as defaults for a bunch of OTEL functions and we'll likely use it that way in the future too. While it's always helpful to have a way to manually set the providers (and not rely on the global providers), setting the global providers from the main function is generally the correct thing to do. This also removes the need for us to use the `WithTracerProvider` and `WithMeterProvider` option to the grpc stats handler as it will use the global configuration if this option isn't set. Since this code is in the main function too, it's safe to rely on that behavior. Signed-off-by: Jonathan A. Sternberg <[email protected]>
There was a problem hiding this comment.
I don't think we should add this. At least for the traces. The tracing context contains the parent definition and the tracer definition. If it is missing for some reason then the span would be created with wrong parent as well in wrong position of the trace that we want to avoid. We can always get correct one from context so don't need additional method.
This also removes the need for us to use the WithTracerProvider and WithMeterProvider option to the grpc stats handler as it will use the global configuration if this option isn't set.
Same could be said for any other function parameter where instead of passing the config packages could communicate via both reading/writing same public global variable. But it is considered a code smell in Go and at least should not be used in reusable library packages. I don't see a big reason why we should completely limit ourself to single tracerprovider, if not for anything else I could see the multiple being useful at least for tests.
The global handlers are used as defaults for a bunch of OTEL functions and we'll likely use it that way in the future too. While it's always helpful to have a way to manually set the providers (and not rely on the global providers), setting the global providers from the main function is generally the correct thing to do.
This also removes the need for us to use the
WithTracerProviderandWithMeterProvideroption to the grpc stats handler as it will use the global configuration if this option isn't set. Since this code is in the main function too, it's safe to rely on that behavior.