Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Flask example #488

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

bevennyamande
Copy link

  • Declare variables inside an application context, i encountered an issue when i was testing an application whilst i was logged into facebook
  • Adding changes to flask.ext.sqlalchemy accordingly
  • Updated current version of facebook API

Copy link
Member

@martey martey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. This looks good, but I would appreciate it if you could use black to ensure that your changes are linted correctly (see https://app.circleci.com/pipelines/github/mobolic/facebook-sdk/45/workflows/6d6de8b8-dd50-46ef-a938-fda63f05ec37/jobs/871/parallel-runs/0/steps/0-103?invite=true).

@martey martey changed the title Adding global vars into app context update Flask example Feb 23, 2021
@bevennyamande
Copy link
Author

Ok thanks for the review let me check using black , but i think this repo needs updates accordingly as the Facebook Graph API is also changing

@bevennyamande
Copy link
Author

I dont know where and how my build are failing will have a look at the deeper code

Copy link
Member

@martey martey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the [contributing guidelines:

A pull request should only include commits directly applicable to its change (e.g. a pull request that adds a new feature should not include PEP8 changes in an unrelated area of the code).

As per the link in my previous comment, you only needed to lint examples/flask/app/views.py. If you want to add support for new versions of the Graph API, or change how the library determines what default version to use, you should create a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants