Use json instead of data argument for requests. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json will behave the same as data except in the case of lists, which will now correctly JSON encode the post_args.
martey
requested changes
Dec 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonwill behave the same asdataexcept in the case of lists, which will now correctly JSON encode the post_args.Note that since the post_args are created in this library, a consumer cannot simply encode the data as json to be passed to the graph.put_objects call, so this change is necessary to allow access to any facebook API that uses arrays, such as forms which require an array of question objects https://developers.facebook.com/docs/graph-api/reference/page/leadgen_forms/