-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding APIs for app test user. #172
base: master
Are you sure you want to change the base?
Conversation
@@ -293,6 +293,38 @@ def get_app_access_token(self, app_id, app_secret): | |||
|
|||
return self.request("oauth/access_token", args=args)["access_token"] | |||
|
|||
def create_app_test_user(self, app_id, app_access_token, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be simpler and more consistent if all methods were called *_test_user
(i.e. create_test_user
, edit_test_user
, get_test_users
, etc.).
I am not sure some of the docstrings are actually useful (e.g. it's obvious that the |
In order to release 1.0.0 as soon as possible, I am moving this to the 2.0.0 milestone. This isn't a reflection of the quality of your pull request, but of the lack of free time I currently have to devote to this project. |
Got it. Thanks. But actually, I still feel sorry for quite poor quality of my PR, while still not sure how to improve it. |
This commit is sample implementation of #96.
Since
TestGetAppAccessToken
fromtest/test_facebook.py
does not guarantees a valid app access token, how should I write meaningful test codes?