fixed-issue-175/Fixed-Duplicate-Code

[uchiha-vivek]

Description

Fix Duplicate Code in Multiple File

The Duplicate code was found in following components

• [packages\core\admin\src\app\modules\shared\inputs\url-input\url-input.component.ts:30-44]
• [packages\core\admin\src\app\modules\shared\inputs\timestamp-input\timestamp-input.component.ts:27-42]
• [packages\core\admin\src\app\modules\shared\inputs\textarea-input\textarea-input.component.ts:29-44]
• [packages\core\admin\src\app\modules\shared\inputs\text-input\text-input.component.ts:28-42]

Solution
_Created a seperate folder name base-input where all the code which was getting repeated are written ! _

How can it be tested?

All the builds are successfull

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
manifest-schema	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 10:40am

[uchiha-vivek]

Any suggestion would be appreciated !

[SebConejo]

@uchiha-vivek Thank you for your PR.

This PR contains a lot of erros. Here is a list of what I can see:

• The goal was to avoid duplicate code in 4 files. Your PR contains changes on 12 files
• You pushed a token secret key. It's not related to this work.
• Did you try to serve the app ? It's interesting to test if the tool works after any contribution.
• You changed the schema URL whereas it was necessary to interprete the code. Why ?
• You have added analytics in angular.json file.
• You removed all the input imports. And a lot of code reagrding the inputs. Why ?

Look, In the current version, it's quite difficult to contribute by testing the rendering as a user. We'll soon deploy a new version that will make contributions much easier. This version should arrive at the beginning of Hacktoberfest. I recommend that you wait for that moment before reworking any issues. What do you think? Let me know, and we will close this PR.

[uchiha-vivek]

@SebConejo
I will fix all the issues as soon as possible .